[v2] Node Checker for the new (v2) AST #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
teofr
force-pushed
the
teofr/node_checker
branch
2 times, most recently
from
acfa26c to
4cc4786
Compare
teofr
force-pushed
the
teofr/node_checker
branch
from
4cc4786 to
072144d
Compare
teofr
force-pushed
the
teofr/node_checker
branch
from
072144d to
d95ed0d
Compare
teofr
force-pushed
the
teofr/node_checker
branch
from
d95ed0d to
db16409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a node checker for the new AST (#1493), it defines a trait to be implemented over the new nodes.
An important note, I use V1 nodes rather than a cursor since it's easier to track what I've seen and what I haven't seen. I found it difficult with a cursor to keep track of the children of a given node that had been processed already, and to traverse them in an arbitrary order. Since this comparison mechanism is temporary I think this solution is ok, but it does mean all the offset calculation is being done again.